Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetEEPROM: Add library.properties #24

Merged

Conversation

per1234
Copy link

@per1234 per1234 commented Mar 3, 2016

A completely different NetEEPROM library was added to Library Manager so a unique library.properties name value for the Ariadne NetEEPROM library is necessary to avoid NetEEPROM appearing as Type: Updatable in Arduino IDE Library Manager and receiving spurious updatable library notifications in Arduino IDE 1.6.6+. If the "update" is installed it will override the Ariadne version of NetEEPROM.
clipboard02

I'm happy to make any changes requested and squash to a single commit.

A completely different NetEEPROM library was added to Library Manager so
a unique library.properties name value for the Ariadne NetEEPROM library
is necessary to avoid spurious updatable library notifications.
@loathingKernel
Copy link

I wonder if it might be better to re-write Ariadne's NetEEPROM to use the included NetEEPROM and just rename our NetEEPROM into something else, if another layer of abstraction is needed, that is. What is your opinion on this?

@per1234
Copy link
Author

per1234 commented Mar 4, 2016

Greg Tan's NetEEPROM isn't actually included with the Arduino IDE. It's just in the index of libraries available for installation via Library Manager. Since it has the same name as the Ariadne NetEEPROM, Library Manager is fooled into thinking that Greg Tan's NetEEPROM is installed and a newer version is available for updating. Updatable library popup notifications were added in Arduino IDE 1.6.6 and these just keep coming until you update. I haven't looked at Greg Tan's library thoroughly enough to see how feasible it would be to use it to set the Ariadne network settings but this would require the user to install Greg Tan's NetEEPROM library as well as installing Ariadne so that would make the process of getting started using Ariadne a little more complex.

@loathingKernel
Copy link

I see. Thanks for the information and the pull request, I am merging this right away then.

loathingKernel added a commit that referenced this pull request Mar 4, 2016
@loathingKernel loathingKernel merged commit 3bca71f into codebndr:master Mar 4, 2016
@per1234 per1234 deleted the neteeprom-library-properties branch March 4, 2016 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants