Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenide calls SeleniumException.getMessage() multiple times #415

Closed
asolntsev opened this issue Oct 14, 2016 · 0 comments
Closed

Selenide calls SeleniumException.getMessage() multiple times #415

asolntsev opened this issue Oct 14, 2016 · 0 comments
Milestone
3/11

Comments

@asolntsev
Copy link
Member

The problem is that SeleniumException.getMessage() can be very slow (it tries to detect IP and name of current machine).

I believe it should be fixed in Selenium, and there is even a pull request for this.
But meanwhile, we could optimize Selenide a little bit to avoid executing getMessage() multiple times.
@asolntsev asolntsev added this to the 3/11 milestone Oct 14, 2016
@asolntsev asolntsev changed the title Selenide calls SeleniumException.getMessage() to many times Selenide calls SeleniumException.getMessage() multiple times Oct 14, 2016
asolntsev added a commit that referenced this issue Oct 14, 2016
@asolntsev
#415 avoid executing SeleniumException.getMessage() multiple times
c70022f
BorisOsipov pushed a commit to BorisOsipov/selenide that referenced this issue Nov 23, 2016
@asolntsev
selenide#415 avoid executing SeleniumException.getMessage() multiple …
d9d9a83 
…times
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3/11
Development

No branches or pull requests
1 participant
@asolntsev