Make screenshot of SelenideElement/WebElement which is inside iframe

[andrejska]

Proposed changes

New feature: added possibility to make a screenshot of SelenideElement or WebElement which is inside iframe

Checklist

• Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[rosolko]

@andrejska For first why don't you cover this feature with tests?
For second wht don't you reuse exist method for takeScreenshotAsImage(WebElement element) with minimal extend for frame switch?
Also isn't it work for you just take screenshot of frame?
What behavior do you expect if iframe or element inside iframe doesn't exist?

[coveralls]

Coverage increased (+1.3%) to 66.812% when pulling f4e91e4 on andrejska:master into 1c98a7a on codeborne:master.

[codecov-io]

Codecov Report

Merging #705 into master will increase coverage by 1.67%.
The diff coverage is 51.57%.

@@             Coverage Diff              @@
##             master     #705      +/-   ##
============================================
+ Coverage     61.81%   63.48%   +1.67%     
- Complexity      827      862      +35     
============================================
  Files           154      154              
  Lines          2891     2977      +86     
  Branches        281      288       +7     
============================================
+ Hits           1787     1890     +103     
+ Misses          996      988       -8     
+ Partials        108       99       -9

Impacted Files	Coverage Δ	Complexity Δ
.../main/java/com/codeborne/selenide/Screenshots.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../codeborne/selenide/impl/ScreenShotLaboratory.java	59.09% <52.68%> (+3.02%)	42 <15> (+8)	⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java	80.88% <0%> (-0.74%)	30% <0%> (ø)
...ava/com/codeborne/selenide/commands/GetParent.java	100% <0%> (ø)	3% <0%> (+1%)	⬆️
...a/com/codeborne/selenide/commands/SelectRadio.java	100% <0%> (ø)	6% <0%> (+1%)	⬆️
...deborne/selenide/commands/SelectOptionByValue.java	100% <0%> (ø)	5% <0%> (+1%)	⬆️
...e/selenide/commands/SelectOptionByTextOrIndex.java	100% <0%> (ø)	8% <0%> (+1%)	⬆️
.../java/com/codeborne/selenide/commands/GetText.java	100% <0%> (ø)	4% <0%> (+1%)	⬆️
...a/com/codeborne/selenide/commands/SetSelected.java	95.65% <0%> (+0.91%)	10% <0%> (+1%)	⬆️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c98a7a...f4e91e4. Read the comment docs.

[rosolko]

@andrejska ping!

[andrejska]

@rosolko

For first why don't you cover this feature with tests?

Tests added

For second wht don't you reuse exist method for takeScreenshotAsImage(WebElement element) with minimal extend for frame switch?

Difference between taking screenshot of element inside iframe and regular element screenshot is big, so reusability of this method will just add more complexity

Also isn't it work for you just take screenshot of frame?

For my specific use case I need a screenshot of webelement inside iframe

What behavior do you expect if iframe or element inside iframe doesn't exist?

Behavior implemented, warning message and returning null, similar approach as in takeScreenshotAsImage

[andrejska]

@rosolko can you please check?

[rosolko]

@andrejska Hey, looks better now, but unfortunately you didn't add any tests for new command takeScreenShot that return File, that why coverage still failing.

Also I want to clarify why method signature takes WebElement element for first and then WebElement iframe, from my point of view - more semantic flow is iframe for first and element for second, because you look up element inside iframe and before all you switch to iframe, and work with it first.

Also I'm not sure about such complex method takeScreenshotAsImage that return BufferedImage, I'll take a look at them soon.
But anyway, thanks for PR.

[andrejska]

@rosolko did changes according to your latest comment, added missing tests & semantic change in order of parameters, please check

[rosolko]

@andrejska LGTM.
@asolntsev @BorisOsipov Any comments?

[BorisOsipov]

Also I'm not sure about such complex method takeScreenshotAsImage that return BufferedImage, I'll take a look at them soon.

+1 It looks nasty.

No other objections.

[andrejska]

@rosolko, @BorisOsipop what are next steps :)?

[rosolko]

@andrejska Sorry for long response. I'll take a look at this PR today and if I can't decrease complexity of method fastly - I'll merge it.

[asolntsev]

@andrejska @rosolko Thanks for the PR! Merged to Selenide 4.11.2