-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildscript and wrapper. #707
Conversation
Apply plugins using new mechanism. Update libs and tools: * pitest -> 1.3.0 * guava -> 24.1-jre * htmlunit-driver -> 2.29 * mockito-core -> 2.16.0 * jetty-server -> 9.4.9.v20180320
Simplify selenium-java dependency. Fix selenide impl package info javadoc.
Simplify deploy gradle file.
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
============================================
+ Coverage 61.87% 61.88% +0.01%
+ Complexity 825 824 -1
============================================
Files 154 154
Lines 2888 2881 -7
Branches 284 281 -3
============================================
- Hits 1787 1783 -4
+ Misses 993 992 -1
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rosolko!
LGTM.
Two minor questions
|
|
@BorisOsipov Yes, a long time ago I tried PiTest. Generally, it would be good to run mutation tests. But de-facto I never run them. It's hard to analyze them because they give too many false results. But feel free to restore them. :) |
Proposed changes
First iteration of gradle update:
Next step: Refactor code style script and update code related to changes.
Checklist
gradle check chrome htmlunit
command