Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildscript and wrapper. #707

Merged
merged 10 commits into from
Mar 28, 2018
Merged

Update buildscript and wrapper. #707

merged 10 commits into from
Mar 28, 2018

Conversation

rosolko
Copy link
Collaborator

@rosolko rosolko commented Mar 26, 2018

Proposed changes

First iteration of gradle update:

  • Update gradle wrapper to use native non custom paths and scripts.
  • Update travis ci scripts.
  • Migrate to new gradle dependencies endpoints.
  • Clean-up deploy buildscript.
  • Remove pitest because unused.
  • Migrate from findbugs to spotbugs.

Next step: Refactor code style script and update code related to changes.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Apply plugins using new mechanism.
Update libs and tools:
* pitest -> 1.3.0
* guava -> 24.1-jre
* htmlunit-driver -> 2.29
* mockito-core -> 2.16.0
* jetty-server -> 9.4.9.v20180320
Simplify selenium-java dependency.
Fix selenide impl package info javadoc.
Simplify deploy gradle file.
@rosolko rosolko self-assigned this Mar 26, 2018
@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #707 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #707      +/-   ##
============================================
+ Coverage     61.87%   61.88%   +0.01%     
+ Complexity      825      824       -1     
============================================
  Files           154      154              
  Lines          2888     2881       -7     
  Branches        284      281       -3     
============================================
- Hits           1787     1783       -4     
+ Misses          993      992       -1     
+ Partials        108      106       -2
Impacted Files Coverage Δ Complexity Δ
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.61% <0%> (-1.48%) 30% <0%> (-1%)
...rne/selenide/impl/DownloadFileWithHttpRequest.java 80% <0%> (-0.29%) 13% <0%> (ø)
...rne/selenide/impl/DownloadFileWithProxyServer.java 94.73% <0%> (-0.14%) 9% <0%> (ø)
.../codeborne/selenide/impl/ScreenShotLaboratory.java 56.06% <0%> (+1.57%) 34% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112ccad...4ee4eba. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 65.568% when pulling 4ee4eba on rosolko:gradle into 112ccad on codeborne:master.

Copy link
Member

@BorisOsipov BorisOsipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rosolko!
LGTM.

@BorisOsipov
Copy link
Member

Two minor questions

  1. What do you mean "Next step: Refactor code style script and update code related to changes."? which changes are you talking about?
  2. @rosolko @asolntsev What about pitest? can't we enable it again?

@rosolko
Copy link
Collaborator Author

rosolko commented Mar 26, 2018

@BorisOsipov

  1. Add pmd, errorprone and sonarqube.
    Use more checkstyle rules.
    Investigate if it's possible to simplify config.
    Move code quality tasks and configs to separate script?
    Style code after new tools and configs.

  2. As discussed with @asolntsev pitests ran few times just for fun and not on regular base, so consider to remove.

@asolntsev
Copy link
Member

@BorisOsipov Yes, a long time ago I tried PiTest. Generally, it would be good to run mutation tests. But de-facto I never run them. It's hard to analyze them because they give too many false results.

But feel free to restore them. :)

@asolntsev asolntsev merged commit e94e0c0 into selenide:master Mar 28, 2018
@asolntsev asolntsev added this to the 4.11 milestone Mar 28, 2018
@rosolko rosolko deleted the gradle branch March 29, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants