Fix #725 remote browser binary #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add info logging for usage of browserBinary
BorisOsipov
requested changes
May 4, 2018
| @@ -52,6 +57,20 @@ DesiredCapabilities getDriverCapabilities(Proxy proxy) { | |||
| if (headless) { | |||
| capabilities.merge(getHeadlessCapabilities()); | |||
| } | |||
| if (!browserBinary.isEmpty()) { | |||
| log.info("Using browser binary: " + browserBinary); | |||
There was a problem hiding this comment.
Consider extract this block to separate method like for getHeadlessCapabilities()
| class SafariDriverFactory extends AbstractDriverFactory { | ||
|
|
||
| private static final Logger log = Logger.getLogger(OperaDriverFactory.class.getName()); |
There was a problem hiding this comment.
OperaDriverFactory => SafariDriverFactory
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
============================================
- Coverage 63.36% 62.95% -0.41%
- Complexity 864 870 +6
============================================
Files 154 154
Lines 2989 3021 +32
Branches 291 297 +6
============================================
+ Hits 1894 1902 +8
- Misses 996 1019 +23
- Partials 99 100 +1
Continue to review full report at Codecov.
|
|
@BorisOsipov fixed |
BorisOsipov
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for using browserBinary on Remote Servers
extended logging