Prevent crashes when calling deprecated functions #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated functions such as
+[TBXML tbxmlWithXMLData:]
were passing a nullerror
pointer to other methods. This leads to a crash if an error occurs and the error-handling code doesn't check for a null pointer before setting the error.These methods are deprecated, so callers shouldn't be using them, but legacy code should not crash.
This commit solves that problem by creating a local
NSError
reference and passing a pointer to that. For example:A test case has been added. This test case crashed before the fixes were made.