tango-dark theme: Changed caret color #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Matthew, looking the original code in https://github.com/barryvan/Geany-Tango-Dark/blob/master/geany-tango-dark.conf and the historý of this repo, the problem seems to be a simple typo; the caret should be white. But note that changing it to white means to adapt brace_good and brace_bad too (at least; maybe others too). |
|
I made some changes after this PR. Please test and offer alternative pull request if you don't like, or I can revert fa56dbe. I don't use this theme much so you guys tell me :) |
|
It's a good improvement. |
|
Mixed capitalization? :P |
|
Darn I thought I got it all (I used Geany's colour tool), oh well :) |
|
@codebrainz I like both! 👍 You don't have to revert anything. |
codebrainz
pushed a commit
that referenced
this pull request
Jun 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw several comments in the internet on changing the cursor color in the tango-dark theme. Sometimes, it was really difficult to find the cursor. I changed the cursor color to #ff0000 (red). It should be a lot easier to find the cursor now.