Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable some part of geanypy-encodings.[ch] which are not part of Gea… #38

Merged
merged 1 commit into from Jan 10, 2016

Conversation

kugel-
Copy link
Collaborator

@kugel- kugel- commented Jan 4, 2016

I'll push this to master soon if there're no objections.

@b4n
Copy link
Collaborator

b4n commented Jan 5, 2016

Bah, just delete everything, at worse it'll be in the VCS history

@codebrainz
Copy link
Owner

Yeah, rather have the code removed than commented/#if-ed out. Make it easier to review the diff too.

@kugel-
Copy link
Collaborator Author

kugel- commented Jan 5, 2016 via email

@codebrainz
Copy link
Owner

@kugel- Except for the empty geanypy-encoding.h header, it looks OK to me. I haven't tested it yet, but as long as you have and are confident it won't break the build/runtime, it's fine by me if you merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants