Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING ISSUE - API] Add Projects Endpoint #79

Closed
BethanyG opened this issue Feb 21, 2020 · 21 comments
Closed

[TRACKING ISSUE - API] Add Projects Endpoint #79

BethanyG opened this issue Feb 21, 2020 · 21 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed needs discussion The fix for this issue needs discussion stale
Milestone

Comments

@BethanyG
Copy link
Member

BethanyG commented Feb 21, 2020

Add a Osprojects api endpoint.

Goal: Create an API endpoint that allows users to submit open source projects to invite collaborators to.

This is a Tracking Issue, individual task issues linked:

working branch: issue-79-add-projects-endpoint
[x] Create osprojects app, apps.py #81
[x] Create osprojects model & associated DB migration files #80
[IN PROGRESS - BLOCKED by error] Create osprojects admin view and register app with Django admin interface #84
[ ] Create JSON spec for osprojects api endpoint #77
[ ] Create sample data/mocked data fixture for osprojects api endpoint #76
[ ] Create osprojects views & queries #82
[ ] Create osprojects serializer #83
[ ] Create osprojects URLs (api\v1\projects, and any others needed) #85
[ ] Ensure associated unittests and test data are created for all code changes
[ ] Document expected GET, POST, PATCH behavior and any other endpoint-specific docs

[ ] Complete Unit Tests for #80 & #81 -- #179 -- Tests were left off for these PRs, and need to be completed ASAP.

@BethanyG
Copy link
Member Author

BethanyG commented Feb 21, 2020

Proposing this as a workflow for adding endpoints, and breaking down the tasks into smaller pieces. Using osprojects as a test run.

We'd make a tracking issue like this one for an endpoint, and then list out the different tasks/issues/points for discussion in their own issues that can be individually assigned to different people if needed.

Not sure if I got the separation quite correct here - there may be dependencies in Django I am not remembering. For instance, you can't make any views without a model...so models have to happen first..but views and models don't have to be done by the same person. Likewise for serializers, URL maps or the admin view.

Thoughts? It's a bit intimidating to have responsibility for an entire endpoint. There are a lot of small annoying details. That being said, it is also hard to coordinate multiple people working on one, and making sure everything is checked off.

@BethanyG BethanyG added documentation Improvements or additions to documentation help wanted Extra attention is needed needs discussion The fix for this issue needs discussion labels Feb 21, 2020
@lpatmo
Copy link
Member

lpatmo commented Feb 22, 2020

I pushed up a branch (empty right now) that folks could check out to commit to: issue-79-add-projects-endpoint

Thanks for listing all this out and the details here, @BethanyG!

@billglover billglover added this to the projects milestone Feb 22, 2020
@bkbuilt bkbuilt self-assigned this Feb 24, 2020
@billglover
Copy link
Contributor

I'd like to see if we can get into the habit of merging in smaller changes and tracking all the issues required to ship a feature as a milestone. For example, we can create mock data, merge it to master and continue shipping without needing to hold back those changes. We tend to trip up with larger PRs.

I do think shipping and entire endpoint requires some coordination, and probably some proactive encouragement to progress, assign, support and work on all required issues. Progress towards a milestone that can be released feels like it might provide a sense of working towards something.

I've set up milestones for bot Resources and Projects so you can see what I'm think. I can remove these if not desired.

@lpatmo
Copy link
Member

lpatmo commented Feb 27, 2020

I've set up milestones for bot Resources and Projects so you can see what I'm thinking.

Thank you! Using this GitHub feature makes a lot of sense. Seeing all the tasks laid out visually in an issue is helpful too, but in the past I've also gotten into the problem of forgetting which issue is the 'master' issue.

I'd like to see if we can get into the habit of merging in smaller changes
💯

@BethanyG BethanyG changed the title [API] Add Projects Endpoint [TRACKING ISSUE][API] Add Projects Endpoint Mar 4, 2020
@BethanyG
Copy link
Member Author

BethanyG commented Mar 4, 2020

Stealing an idea from PyLadies, which names all their "epics" as [TRACKING ISSUE]. Can remove if this is too visually noisy.

@BethanyG
Copy link
Member Author

Closing this. It has had no activity since March, and it feels like development is moving in a different direction ATM.

@lpatmo
Copy link
Member

lpatmo commented Aug 21, 2020

Re-opening this to use as sandbox issue :)

@lpatmo lpatmo reopened this Aug 21, 2020
@BethanyG
Copy link
Member Author

@lpatmo -- is @bkbuilt still working on this, or is this now something you are working on? Do the associated issues also need to be reopened?

@BethanyG BethanyG changed the title [TRACKING ISSUE][API] Add Projects Endpoint [TRACKING ISSUE - API] Add Projects Endpoint Aug 23, 2020
@lpatmo
Copy link
Member

lpatmo commented Aug 24, 2020

I believe @bkbuilt is focused on issue-55-post-resource right on the frontend now (PS let me know if you need help or want to pair on it again, @bkbuilt, and I will schedule a time to focus on it!)

@watchtheblur may be interested in pairing on the "adding a new endpoint" workflow, and we'll make sure to re-open the associated issues as we do each step. Thanks!

@lpatmo lpatmo assigned lpatmo and watchtheblur and unassigned bkbuilt Aug 24, 2020
This was referenced Aug 27, 2020
@BethanyG
Copy link
Member Author

BethanyG commented Sep 8, 2020

@lpatmo @watchtheblur -- tests were left off of PRs #169 and #170. Rather than revert those and create problems for myself and others, I've opened a new issue for the missing tests. Let's make sure we get them completed as soon as possible. Otherwise, we can't call this complete. Thanks!

@stale stale bot removed the stale label Dec 10, 2020
@stale
Copy link

stale bot commented Feb 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 8, 2021
@BethanyG
Copy link
Member Author

BethanyG commented Feb 8, 2021

Still open. Just sleeping.

@stale stale bot removed the stale label Feb 8, 2021
@stale
Copy link

stale bot commented Apr 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 9, 2021
@BethanyG BethanyG removed the stale label Apr 10, 2021
@stale
Copy link

stale bot commented Jun 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 10, 2021
@stale stale bot closed this as completed Jun 17, 2021
@BethanyG BethanyG reopened this Jun 17, 2021
@stale stale bot removed the stale label Jun 17, 2021
@stale stale bot added the stale label Aug 16, 2021
@BethanyG BethanyG removed the stale label Aug 16, 2021
@stale stale bot added the stale label Oct 15, 2021
@BethanyG BethanyG removed the stale label Oct 15, 2021
@codebuddies codebuddies deleted a comment from stale bot Oct 15, 2021
@codebuddies codebuddies deleted a comment from stale bot Oct 15, 2021
@BethanyG BethanyG reopened this Oct 15, 2021
@stale
Copy link

stale bot commented Dec 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 14, 2021
@stale stale bot closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed needs discussion The fix for this issue needs discussion stale
Projects
None yet
Development

No branches or pull requests

5 participants