Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made sidebar of study group hideable #630

Merged
merged 7 commits into from
Oct 2, 2017
Merged

Made sidebar of study group hideable #630

merged 7 commits into from
Oct 2, 2017

Conversation

aewens
Copy link
Contributor

@aewens aewens commented Oct 1, 2017

Fixes #628 .

Adds the show-sidebar and hide-sidebar and their respective events/styling to study group.

lpatmo
lpatmo approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@lpatmo lpatmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect -- thanks for figuring out the pattern from the hangouts feature and for replicating, @aewens!

@lpatmo
Copy link
Member

lpatmo commented Oct 2, 2017

(And thanks for adding yourself to the contributors' list.)

@lpatmo lpatmo merged commit 7b46928 into codebuddies:staging Oct 2, 2017
@lpatmo lpatmo added [state] closed the issue is now closed, see comments for more information and removed Waiting For Review labels Oct 2, 2017
@lpatmo lpatmo mentioned this pull request Oct 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatmo lpatmo lpatmo approved these changes

Assignees
No one assigned
Labels
[state] closed the issue is now closed, see comments for more information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aewens @lpatmo