New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 668 study group announcement #680
Merged
lpatmo
merged 14 commits into
codebuddies:staging
from
railsstudent:issue-668-study-group-announcement
Oct 21, 2017
Merged
Issue 668 study group announcement #680
lpatmo
merged 14 commits into
codebuddies:staging
from
railsstudent:issue-668-study-group-announcement
Oct 21, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatmo
added
the
[state] in-review
the implementation that addresses this issue is up for review
label
Oct 20, 2017
So excellent. Thank you @railsstudent! |
lpatmo
approved these changes
Oct 21, 2017
lpatmo
added
[state] closed
the issue is now closed, see comments for more information
and removed
[state] in-review
the implementation that addresses this issue is up for review
labels
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668.
When study group is created, the method called studyGroupNotification() in slack/method.js to send simple text message to channel.
Study group notification uses notebook emoji and 'Study Group Alerts' username to display alert in the channel.
Username is defined as a property in setting-development.json; therefore, a corresponding entry should exist in production config in production hosting location.