Easy fix: Rename to #683 #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stain88
reviewed
Oct 21, 2017
i18n/en.i18n.json
Outdated
| @@ -138,7 +138,7 @@ | |||
| "members": "Members", | |||
| "learnings": "Progress Log", | |||
| "links": "Links", | |||
| "resources": "Resources", | |||
| "links": "Links", | |||
There was a problem hiding this comment.
Does links need to be in here twice?
There was a problem hiding this comment.
You're right. Will fix it
| @@ -80,7 +80,7 @@ | |||
| <li role="presentation"><a href="#hangouts" aria-controls="hangouts" role="tab" data-toggle="tab">{{_ 'hangouts'}}</a></li> | |||
| <li role="presentation"><a href="#members" aria-controls="members" role="tab" data-toggle="tab">{{_ 'members'}} ({{ members.length }})</a></li> | |||
| <li role="presentation"><a href="#learnings" aria-controls="learnings" role="tab" data-toggle="tab">{{_ 'learnings'}} ({{ learningsCount }})</a></li> | |||
| <li role="presentation"><a href="#resources" aria-controls="resources" role="tab" data-toggle="tab">{{_ 'resources'}} ({{ resourcesCount }})</a></li> | |||
| <li role="presentation"><a href="#resources" aria-controls="resources" role="tab" data-toggle="tab">{{_ 'links'}} ({{ resourcesCount }})</a></li> | |||
There was a problem hiding this comment.
Shall I change all the attributes/links from 'resources' to 'links' or just the name of the link?
|
Thanks for the PR @kristinakarnitskaya and thanks for reviewing, @stain88! |
lpatmo
approved these changes
Oct 21, 2017
lpatmo
added
[state] closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue number>.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue above.
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
Always follow the contribution guidelines when submitting a pull request.