Language switching and local storage persistence #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatmo
added
the
[state] in-review
|
Hey @ajparise, thanks for your PR. Does it need a review yet? |
|
@nalbina It's ready for a review. Thanks! |
nalbina
reviewed
Nov 22, 2017
client/templates/home/footer.js
Outdated
| const languageCode = event.target.dataset.langCode | ||
| const languageName = event.target.dataset.langName | ||
|
|
||
| TAPi18n.setLanguage(languageCode) |
There was a problem hiding this comment.
I feel like setting the same language again should be a noop. right now I am getting a notification for each click.
There was a problem hiding this comment.
Makes sense and was intentional, but valid point. I added a guard clause.
client/templates/home/footer.js
Outdated
| console.log(error); | ||
| }) | ||
| .always(() => { | ||
| localStorage.setItem('lang', TAPi18n.getLanguage()); |
There was a problem hiding this comment.
Can we call the localstorage item also languageCode to stay in sync with the rest? :)
There was a problem hiding this comment.
Good catch, updated in all related files.
client/templates/main.js
Outdated
| @@ -9,14 +9,14 @@ if (Meteor.isClient) { | |||
| } | |||
|
|
|||
| const defaultLang = 'en' | |||
| const urlLang = FlowRouter.getQueryParam('lang') | |||
| const localStorageLang = localStorage.getItem('lang'); | |||
There was a problem hiding this comment.
Can we call the localstorage item also languageCode to stay in sync with the rest? :)
lpatmo
added
[state] closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplements #446, #730.
TAPi18n.getLanguages()