New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/291 iconborderwidth doesnt work #351

Merged

codebude merged 2 commits into master from bugfix/291-iconborderwidth-doesnt-work

Nov 23, 2021

Owner

codebude commented Nov 23, 2021 •

edited

Summary
This PR fixes/implements the following bugs:

The icon's border wasn't rendered (due to a former code removal, which made the parameter useless)
The previous method for border rendering was refactored, to work without Region.Exclude(path) (which earlier led to problems on Linux environments)
More testcases were written and existing ones improved

Test plan

Closing issues
Fixes #291

codebude added 2 commits

November 23, 2021 22:46


          Fixed icon-border/-background rendering

05a1e53


          Updated and added new testcases for QRCodeRenderer

940798b

codebude merged commit f10daa1 into master

codebude deleted the bugfix/291-iconborderwidth-doesnt-work branch

November 23, 2021 22:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment