Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string optimizations #521

Merged
merged 10 commits into from May 13, 2024
Merged

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented May 7, 2024

This PR prevents PlainTextToBinaryByte from encoding the provided string back and forth to the target encoding multiple times. It also caches the encoder for future use, as it is designed to be a singleton. On the .NET Core 5+ TFMs the encoding uses a stack-allocated byte array, reducing heap allocations and memory requirements.

Add tests for UTF8 with and without BOM.

No changes to logic; produced QR codes should be identical to previously for any input.

QRCoder/QRCodeGenerator.cs Outdated Show resolved Hide resolved
QRCoder/QRCodeGenerator.cs Show resolved Hide resolved
QRCoder/QRCodeGenerator.cs Outdated Show resolved Hide resolved
@codebude
Copy link
Owner

codebude commented May 9, 2024

Hello @gfoidl , hello @Shane32 - I would like to take this opportunity to say once again that I am very impressed by your suggestions and your discussion. To be honest, your optimizations reach a level that exceeds my knowledge of C#/.NET/JIT. Nevertheless, I think I vaguely understand what you are discussing and I think I have learned a thing or two. Thank you very much for your efforts. I bow my head!

@codebude codebude merged commit 6d41db5 into codebude:master May 13, 2024
3 checks passed
@Shane32 Shane32 deleted the string_optimizations branch May 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants