Add support for optional CNContactUrlAddressesKey field. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kitschpatrol could you rebase this? I'm so sorry it fell off my radar - i'll review it immediately after rebase. |
|
@codebytere Sure thing. No worries on the delay. |
codebytere
approved these changes
Sep 10, 2023
|
Hello and thanks for an amazing library! No pressure at all but it would be great to have this urlAddresses extra prop feature released to NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this excellent library! I needed access to
CNContactUrlAddressesKeyfields in my project, so I added support.Submitting a PR in case it's useful to others.
The contents of the field are made available by passing the
urlAddressesin theextraPropertiesargument array. It behaves much like theemailAddressesfield. (This relates a bit to the discussion in #5)Also added a note to the readme about permission-requesting caveats when invoking the library through an embedded terminal. There's also a bit of extra diff noise in the readme owing to some extra spaces / inconsistent formatting that prettier picked up on.
I didn't see any existing tests related to optional
extraProperties, so I did not add any.