Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple bugs on file headers update #882

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Fixed multiple bugs on file headers update #882

merged 3 commits into from
Nov 30, 2021

Conversation

lflender
Copy link
Contributor

  • Fixed header replacement management: if a header is already present and a new one is added in another place using the "Replace" option, then the old one is removed.
    e.g. if a header is present at document start and we add a new one after usings with the Replace option, the one at document start is now removed
  • Header update on files with no header and no using is now working
  • Header piece being sometimes inserted after header is now fixed

Ludovic Flender added 3 commits November 24, 2021 14:51
…nd a new one is added in another place using the "Replace" option, then the old one is removed.

e.g. if a header is present at document start and we add a new one after usings with the Replace option, the one at document start is now removed
- header update on files with no header and no using is now working
- header piece being sometimes inserted after header is now fixed
@codecadwallader
Copy link
Owner

Wonderful, thank you for making these fixes! :)

@codecadwallader codecadwallader merged commit bb3d309 into codecadwallader:dev Nov 30, 2021
@codecadwallader codecadwallader added this to the v12.1 milestone Nov 30, 2021
@lflender
Copy link
Contributor Author

lflender commented Dec 7, 2021

Hey @codecadwallader, could I know when you plan to release the next version? I would like to use CodeMaid in my company with VS2022 and we need my latest changes. Maybe I could help with some bug fixes if you have set some objectives on that?

@lflender
Copy link
Contributor Author

lflender commented Dec 8, 2021

I'm not used to milestones, just read about them... So a new version will be released after a number of PRs have been completed?

@codecadwallader
Copy link
Owner

codecadwallader commented Dec 9, 2021

Hi @lflender , I don't have the next release planned yet. Your changes should(tm) be available in the CI channel, but that's not as easy for everyone to install/update as an official release. Some bug fix help would be great as there's definitely been an influx with the new VS2022 support!

The most urgent issue on my mind is that with VS2022 (and VS2019) the insert explicit access modifier APIs are misbehaving. Several of the recently created issues (e.g. #879 #866) all tie back to this underlying issue. I think if we had a solution for that it would definitely warrant a release as it would solve several issues.

I mainly use the milestones to link together issues into a release for posterity. The idea being that if you wanted to see the changes in a specific release you could go to that milestone and see all the issues/PRs that were linked.

Thanks for your help! Lets use #879 to communicate any progress on the insert explicit access modifier functionality. That issue has the worst side effect IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants