Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing the Explorer generate a JS error in Mojave #31

Closed
ScrumpyJack opened this issue Dec 8, 2019 · 4 comments
Closed

Accessing the Explorer generate a JS error in Mojave #31

ScrumpyJack opened this issue Dec 8, 2019 · 4 comments
Assignees
Labels
bug Something isn't working needs investigation a bug to be investigated to find out what's wrong

Comments

@ScrumpyJack
Copy link

Start Gopass UI
Close Explorer window
Start Explorer window from the Gopass UI toolbar and you get.

Uncaught Exception:
Error: Object has been destroyed
    at click (/Applications/Gopass UI.app/Contents/Resources/app.asar/dist/main.js:42:3322)
    at MenuItem.click (/Applications/Gopass UI.app/Contents/Resources/electron.asar/browser/api/menu-item.js:56:9)
    at Function.executeCommand (/Applications/Gopass UI.app/Contents/Resources/electron.asar/browser/api/menu.js:31:13)

In addition, search window will allow searching, but clicking on a password path does nothing.

@jonas-pietzsch
Copy link
Contributor

Hey @ScrumpyJack
Thanks for your report. Sorry for the late reply and bad experience with the tool. I'll try to investigate. One question: did Gopass UI work for you before upgrading to Mojave? This would help me understanding it. I'm not on Mojave myself, yet, but in the process of upgrading for myself I will then be able to troubleshoot it. Thanks in advance for your answer

@jonas-pietzsch jonas-pietzsch self-assigned this Jan 2, 2020
@ScrumpyJack
Copy link
Author

Actually this is my first install of gopass-ui. I've not tested it on other that Mojave (and I don't have anything other than Mojave to test it on)

Hey and stop being so nice, it's disconcerting ;)

@jonas-pietzsch jonas-pietzsch added needs investigation a bug to be investigated to find out what's wrong bug Something isn't working labels Jan 13, 2020
@jonas-pietzsch
Copy link
Contributor

Reproduced and fixed on master. The fix will be part of the next release.

@ScrumpyJack
Copy link
Author

Awesome. Will test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs investigation a bug to be investigated to find out what's wrong
Projects
None yet
Development

No branches or pull requests

2 participants