Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional edge cases #33

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Fix additional edge cases #33

merged 5 commits into from
Feb 13, 2024

Conversation

roflmuffin
Copy link
Contributor

@roflmuffin roflmuffin commented Feb 10, 2024

  • Adds support for ref property generation
  • Does a naive de-dupe on name to allow for overriding/new properties with the same name
  • Uses syntax literal identifier text rather than name where possible, to allow for variable names with special symbols like @event

Closes #30, #31 & #32

@roflmuffin roflmuffin changed the title Fix ref duplicate names Fix additional edge cases Feb 10, 2024
@ChristianSauer
Copy link
Collaborator

Hi, this looks good to me. Nice findings.
Can you fix the formatting and the two failing tests?` #nullable enable/ #nullable restore are missing for some reason

@roflmuffin
Copy link
Contributor Author

I have fixed the formatting, but it looks like those two failing tests are also failing in master; though I can take a look if you want?

@ChristianSauer
Copy link
Collaborator

I fixed them. Funny how that got into master.
Thanks a lot!
Will push this as a minor release

@ChristianSauer
Copy link
Collaborator

Ah, I think you need to pull master into your branch once. Sorry!

@roflmuffin
Copy link
Contributor Author

Done, thanks for that! I would have fixed them but had issues with line endings on windows 10 with the tests :(

@ChristianSauer ChristianSauer merged commit 10189b3 into codecentric:master Feb 13, 2024
3 checks passed
@ChristianSauer
Copy link
Collaborator

It's on nuget as 2.2.1
Thanks!

@ChristianSauer
Copy link
Collaborator

The line endings and whitespace are massively annoying. Wish there would be an easy way to test if the generated syntax is correct without caring for whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants