Skip to content

Commit

Permalink
Fix Javadoc errors to build on jdk 11
Browse files Browse the repository at this point in the history
  • Loading branch information
joshiste committed Jul 2, 2019
1 parent 9094ef4 commit eaa9154
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<source>${java.version}</source>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down Expand Up @@ -163,6 +166,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<parameters>true</parameters>
<source>${maven.compiler.source}</source>
<target>${maven.compiler.target}</target>
</configuration>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ protected Application(String name,
this.metadata = new HashMap<>(metadata);
}

public static class Builder {
//Will be generated by lombok
}

public static Builder create(String name) {
return Application.builder().name(name);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ private Registration(String name,
this.metadata = new LinkedHashMap<>(metadata);
}

public static class Builder {
//Will be generated by lombok
}

public static Registration.Builder create(String name, String healthUrl) {
return builder().name(name).healthUrl(healthUrl);
}
Expand All @@ -78,7 +82,7 @@ public static Registration.Builder copyOf(Registration registration) {
}

public Map<String, String> getMetadata() {
return Collections.unmodifiableMap(metadata);
return Collections.unmodifiableMap(this.metadata);
}

/**
Expand Down

0 comments on commit eaa9154

Please sign in to comment.