Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better eureka-based discovery integration #159

Closed
wants to merge 6 commits into from
Closed

Better eureka-based discovery integration #159

wants to merge 6 commits into from

Conversation

jvmlet
Copy link

@jvmlet jvmlet commented Feb 16, 2016

  1. Spring cloud version promoted to Brixton.M3
  2. Added EurekaApplicationDiscoveryListener that properly propagates service-configured health and management URLs to Application

Should address #154

2. Added EurekaApplicationDiscoveryListener that properly propagates service-configured health and management URLs to Application
@jvmlet
Copy link
Author

jvmlet commented Feb 16, 2016

@joshiste , please merge.

@joshiste
Copy link
Collaborator

You better would have done a rebase.... And forced push

@joshiste
Copy link
Collaborator

I started digging into the changes. Unfortunatly the upgrade to a current Brixton build snapshot is not a no-brainer and will take me some days.

@jvmlet
Copy link
Author

jvmlet commented Feb 17, 2016

That's why I've upgraded to Brixton.M3, not to the latest M5 which introduced major non backward compatible API changes.

@joshiste
Copy link
Collaborator

joshiste commented Mar 3, 2016

On hold, until Spring Cloud Brixton is released.

private EmbeddedWebApplicationContext eurekaServer;

@Before
public void setup() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshiste joshiste removed the on hold label Apr 27, 2016
@joshiste
Copy link
Collaborator

joshiste commented Apr 27, 2016

closed by 272633e
I needed to change really a lot. But thanks for the PR anyway. Code and Suggestions are alway welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants