Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hostname of server.address / management.address if set and prefer-ip is false #296

Closed
wants to merge 2 commits into from
Closed

Use hostname of server.address / management.address if set and prefer-ip is false #296

wants to merge 2 commits into from

Conversation

weeniearms
Copy link
Contributor

Fix for #295

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 88.379% when pulling a1e3d15 on weeniearms:1.3.x into ed45e91 on codecentric:1.3.x.

@weeniearms weeniearms changed the title Fix AdminClientProperties not obtaining hostname from server.address if set Fix AdminClientProperties not obtaining hostname from server.address if set (1.3.x) Oct 11, 2016
@weeniearms
Copy link
Contributor Author

The decrease of coverage has to do with the fact that certain lines of code have been removed. No new lines that are not covered with tests have been introduced.

@weeniearms weeniearms mentioned this pull request Oct 11, 2016
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 88.379% when pulling 5407f81 on weeniearms:1.3.x into ed45e91 on codecentric:1.3.x.

@joshiste joshiste mentioned this pull request Oct 11, 2016
Closed
@joshiste joshiste modified the milestones: 1.3.7, 1.4.3 Oct 11, 2016
@joshiste joshiste changed the title Fix AdminClientProperties not obtaining hostname from server.address if set (1.3.x) Use hostname of server.address / management.address if set and prefer-ip is false Oct 11, 2016
@joshiste
Copy link
Collaborator

merged into master and 1.3.x with e8d8058

@joshiste joshiste closed this Oct 11, 2016
@joshiste
Copy link
Collaborator

1.3.7 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client enhancement
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weeniearms @coveralls @joshiste