Use a single browser instance per suite for Protractor/Selenium helper #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2016 15:53
… suite for protractor/selenium tests
This was referenced Jul 22, 2016
Closed
|
Thanks. The feature is good but I think it should be configurable. I will review it tomorrow and if everything is ok I will merge it and try to do same for webdriverio |
|
Thank you. SeleniumWebdriver, Protractor and WebDriverIO has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of opening/closing the browser before/after each tests, this is doing it before/after each suite. Only available for Protractor/Selenium helper at the moment, I'm happy to bring it to webdriver.io if we agree that the feature is good. Also any suggestion/improvement welcome :).
Fix #156
ps: That speeds up the tests as well from 11min to 6