Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add new public api, tests and docs. Typed dataTableArgument #3047

Merged
merged 3 commits into from
Sep 19, 2021
Merged

FEATURE: add new public api, tests and docs. Typed dataTableArgument #3047

merged 3 commits into from
Sep 19, 2021

Conversation

EgorBodnar
Copy link
Contributor

@EgorBodnar EgorBodnar commented Sep 16, 2021

Motivation/Description of the PR

Lack of typing DataTableArgument, it is difficult to work with this class using TS.
Some methods for working with the cucumber-like table are not implemented.

Description of this PR, which problem it solves:

  • Typing an existing DataTableArgument class. Extending its API.
  • Added: rowsHash() and transpose() methods.
  • Added unit tests for new methods.
  • The BDD doc has been expanded and added examples of DataTableArgument usage.
  • Resolves #2081

Applicable plugins:

  • coverage

Type of change

  • 馃殌 New functionality
  • 馃搵 Documentation changes/updates
  • 馃敤 Markdown files fix - not related to source code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@EgorBodnar
Copy link
Contributor Author

@peterngtr @DavertMik review please.

@DavertMik
Copy link
Contributor

Thanks, i will check it today

@EgorBodnar EgorBodnar changed the title FEATURE: add new public api tests and docs. Typed dataTableArgument FEATURE: add new public api, tests and docs. Typed dataTableArgument Sep 17, 2021
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move out DataTableArgument from the core class and export it independently via index.js

lib/codecept.js Outdated Show resolved Hide resolved
@EgorBodnar
Copy link
Contributor Author

@DavertMik review again, please

docs/bdd.md Outdated Show resolved Hide resolved
@DavertMik DavertMik merged commit e4582c2 into codeceptjs:3.x Sep 19, 2021
@DavertMik
Copy link
Contributor

Yes, that's it. Thank you!

@EgorBodnar EgorBodnar deleted the feat/gherkin_DataTableArgument_new_api_typed branch September 19, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing DataTables With headers
3 participants