Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global retry #3667

Merged
merged 1 commit into from
May 28, 2023
Merged

fix: global retry #3667

merged 1 commit into from
May 28, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented May 26, 2023

Motivation/Description of the PR

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DavertMik DavertMik merged commit 5a549b6 into 3.x May 28, 2023
7 checks passed
@kobenguyent kobenguyent deleted the fix-global-retry branch May 28, 2023 15:13
@jhalborg
Copy link

jhalborg commented May 30, 2023

Thank you!

@DavertMik - when can we expect a patch release?

Just tested this change. For the simple config with just a number of retries, i.e. retry: 2,, it works 馃帀 However, the grep functionality does not seem to work still. For example, for a config like this:

retry: [
    {
      Scenario: 1,
      Feature: 1,
    },
    {
      grep: '@flaky',
      Scenario: 4,
      Feature: 3,
    },
  ]

I would expect 1 retry for tests, unless marked with @flaky, in which case more retries would be done. However, this is not the case, and as far as I could see, no tests have been added for the grep functionality in this PR

@ua1wcz
Copy link

ua1wcz commented Apr 17, 2024

@kobenguyent Is it support Gherkin?

cc @DavertMik

Cause what I receiving when trying to use it with Gherkin (Added Before to cover Background)

Error processing suite.before event:
TypeError: Cannot read properties of undefined (reading 'retryBefore')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retry inside codecept.conf.js not working The global retries config option is not applied
5 participants