Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwright): some wait funcs draw error due to switchTo iframe #3918

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • Resolves #issueId (if applicable).

Applicable helpers:

  • Playwright

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik October 10, 2023 00:16
@kobenguyent kobenguyent mentioned this pull request Oct 10, 2023
6 tasks
@kobenguyent kobenguyent merged commit 4c5e2cd into 3.x Oct 21, 2023
9 checks passed
@kobenguyent kobenguyent deleted the fix-some-wait-funcs branch October 21, 2023 05:05
@philkas
Copy link
Contributor

philkas commented Oct 26, 2023

I have a general qustion regarding this whole switchTo(), _getContext and Frame stuff. I have the feeling that this becomes more and more complex. Especially _getContext can return the page or a frameLocator... I think page and frameLocator are different concepts in playwright. To fix the problem with waitForSelector with this change a further special handling is introduced into some wait methods of codeceptjs.
In my opinion i would make more sense, that a switchTo sets the internal state of pages/frames in a accurate way and getContext can return a page or frame object.

@kobenguyent
Copy link
Collaborator Author

Thank you @philkas. Looking forward to seeing your PR to improve this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants