Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppiumTestDistribution/appium-device-farm requires 'platformName' #3950

Merged

Conversation

rock-tran
Copy link
Contributor

Motivation/Description of the PR

  • Description of this PR, which problem it solves

I'm trying to run tests with Appium + it's plugin DeviceFarm.
At the start, the plugin raises the error then I realize it requires the 'platformName' in the capabilities.
I know I may update such plugins ( include AppiumDashboard) but that key is used so many places.
Send duplicated capabilities is easier way to fix it.

  • Resolves #issueId (if applicable).

Applicable helpers:

  • Appium

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • [] 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

I guess this one just clone more key values, and won't break anything. Thanks @rock-tran

@kobenguyent kobenguyent merged commit e590213 into codeceptjs:3.x Oct 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants