Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appium): type of setNetworkConnection() #3994

Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix(appium): type of setNetworkConnection() #3994

merged 3 commits into from
Nov 15, 2023

Conversation

mirao
Copy link
Contributor

@mirao mirao commented Nov 11, 2023

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

kobenguyent
kobenguyent reviewed Nov 13, 2023
View reviewed changes
lib/helper/Appium.js Outdated Show resolved Hide resolved
@kobenguyent kobenguyent changed the title Appium: Fixed type of setNetworkConnection() fix(appium): type of setNetworkConnection() Nov 14, 2023
@kobenguyent kobenguyent merged commit b2a8344 into codeceptjs:3.x Nov 15, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobenguyent kobenguyent kobenguyent approved these changes

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appium: Missing parameter definition in "setNetworkConnection"
3 participants
@mirao @kobenguyent @Arhell