Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waitForText locator issue #4039

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Nov 30, 2023

Motivation/Description of the PR

Fix error

locator.isVisible: Unexpected token "s" while parsing selector ":has-text('Were you able to resolve the resident's issue?') >> nth=0"
      at Playwright.waitForText (node_modules\codeceptjs\lib\helper\Playwright.js:2584:79)

Applicable helpers:

  • Playwright

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator Author

  1) REST - Form upload
       upload file
         should not show error when file size doesnt exceedes the permit:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/codecept/test/rest/REST_test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at process.processTimers (node:internal/timers:512:7)



expected '<h1>Internal Server Error</h1>' to include 'File Uploaded!'

Exited with code exit status 1

just the issue from service not our code. Good to merge!

@kobenguyent kobenguyent merged commit 9d478ef into 3.x Nov 30, 2023
11 of 12 checks passed
@kobenguyent kobenguyent deleted the 4037-re-opening-3987-ignoring-cancel-characters-with-playwright-on-string-locators branch November 30, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-opening #3987: Ignoring cancel characters with playwright on string locators
1 participant