Issue with 'grabAttributeFrom' method #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was just returning 'null' for me otherwise.
|
We need a test for this. In #408 I added instructions for test execution. Could you write a test for this feature? Thanks |
|
Added a test that this pull request fixes. In doing so, I realised that the issue was only with custom attributes - that's why the existing test was passing but I was still having issues. This stackoverflow answer explains what was going on: http://stackoverflow.com/questions/10280250/getattribute-versus-element-object-properties/10280487#10280487 |
|
Thanks for the deep investigation and the fix. Very nice to have this edge cases fixed! |
|
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to use 'getAttribute' to grab an attribute from an element - it was just returning 'null' for me otherwise.