Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapi): add waitForCookie #4169

Merged
merged 7 commits into from
Feb 4, 2024
Merged

feat(webapi): add waitForCookie #4169

merged 7 commits into from
Feb 4, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Waits for the specified cookie in the cookies.

I.waitForCookie("token");

Parameters

  • name [string][9] expected cookie name.
  • sec [number][20] (optional, 3 by default) time in seconds to wait

Returns void automatically synchronized promise through #recorder

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver

Type of change

  • 馃殌 New functionality

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 6f99119 into 3.x Feb 4, 2024
14 checks passed
@kobenguyent kobenguyent deleted the feat-waitForCookies branch February 4, 2024 05:10
@kobenguyent kobenguyent mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature webApi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The waitCookie method is missing
1 participant
@kobenguyent