Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waitfortext doesnt throw error when text doesnt exist #4195

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • fix: waitfortext doesnt throw error when text doesnt exist

This test is passed eventho there is no Dynamic text 123

    it('should wait for text located by XPath', async () => {
      await I.amOnPage('/dynamic');
      await I.dontSee('Dynamic text');
      await I.waitForText('Dynamic text 123', 5, '//div[@id="text"]');
    });

Applicable helpers:

  • Playwright

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 4d91aab into 3.x Feb 15, 2024
12 checks passed
@kobenguyent kobenguyent deleted the fix-waitForText branch February 15, 2024 04:21
@kobenguyent kobenguyent mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants