Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AssetScheme.mint() to AssetScheme.createMintTransaction() #72

Closed
joojis opened this issue Jul 19, 2018 · 2 comments
Closed

Refactor AssetScheme.mint() to AssetScheme.createMintTransaction() #72

joojis opened this issue Jul 19, 2018 · 2 comments
Labels
discussion

Comments

@joojis
Copy link
Contributor

joojis commented Jul 19, 2018 •
edited
Loading

Current:

...
var myAddress = ...
var myAsset = sdk.core.createAsset({ metadata, registrar, amount })
var mintTransaction = myAsset.mint(myAddress)

Proposal:

...
var myAddress = ...
var myAssetScheme = sdk.core.createAssetScheme({ metadata, registrar, amount })
var mintTransaction = myAssetScheme.createMintTransaction({ recipient: myAddress })
@joojis joojis changed the title Refactor AssetScheme.mint to AssetScheme.createMintTransaction Refactor AssetScheme.mint() to AssetScheme.createMintTransaction() Jul 19, 2018
@kseo
Copy link
Member

kseo commented Jul 19, 2018

Let's remove recipient.

@joojis
Copy link
Contributor Author

joojis commented Jul 19, 2018

Patch: d0c467a

@joojis joojis closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kseo @joojis