Skip to content

Commit

Permalink
Remove docker login step from circle yml (#329)
Browse files Browse the repository at this point in the history
This removes the docker login step from our Circle yml. The idea is
that this is pulling the parser image, which was private when we added
this step. However, the parser image is now public.

This is also blocking OSS contributions from users who have forked
duplication, since Circle fails at this step on forks.

Co-authored-by: Max Jacobson <max@hardscrabble.net>
  • Loading branch information
larkinscott and maxjacobson committed Jul 20, 2018
1 parent 0646b13 commit 77e3337
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion circle.yml
Expand Up @@ -12,7 +12,6 @@ dependencies:
--env GCR_JSON_KEY
--volume /var/run/docker.sock:/var/run/docker.sock
codeclimate/patrick pull || true
- docker login --username "$DOCKER_USERNAME" --password "$DOCKER_PASSWORD" --email "$DOCKER_EMAIL"
- make image

test:
Expand Down

0 comments on commit 77e3337

Please sign in to comment.