Make sure version is properly set on CI #21
+6
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
chrishulton
and removed request for
codeclimate-hermes
pointlessone
force-pushed
the
fix-version
branch
from
1dc6f84
to
5d03527
Compare
chrishulton
reviewed
Jan 10, 2018
| @@ -6,14 +6,15 @@ RUN adduser -u 9000 -D app | |||
|
|
|||
| WORKDIR /usr/src/app | |||
|
|
|||
| COPY engine.json /engine.json | |||
There was a problem hiding this comment.
hm, so trying to understand how this worked before - i think the idea was that this layer would control the caching, meaning if this file did not change, it wouldn't re-run the below steps and actually pull in a different go lint version.
running update could potentially change this file (which happened at the beginning of the image command), and break this cache layer, causing the below steps to run and actually pull in that sha. i think this is what we do in api for example with the dockerfile-version file.
what was the problem with how this was working before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go doesn't really lock dep versions so it might change on rebuild. This may result in version being improperly set.
With this change version is updated during image build.