Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop 0.70 released #169

Closed
modosc opened this issue May 13, 2019 · 10 comments
Closed

Rubocop 0.70 released #169

modosc opened this issue May 13, 2019 · 10 comments
Assignees

Comments

@modosc
Copy link

modosc commented May 13, 2019

https://github.com/rubocop-hq/rubocop/releases/tag/v0.69.0

https://github.com/rubocop-hq/rubocop/releases/tag/v0.70.0

@stefanahman
Copy link

Why isn't this automated?

@Mange
Copy link

Mange commented May 14, 2019

Why isn't this automated?

…or using the version from the Gemfile of the project.

I suspect it has to do with how the report is digested and used in the interface, but I can only guess.

@modosc
Copy link
Author

modosc commented May 14, 2019

alternately - if bandwidth is an issue on the codeclimate side why not make this a community maintained image?

@Fryguy
Copy link

Fryguy commented May 16, 2019

Why isn't this automated?

Likely because rubocop doesn't follow SemVer and constantly breaks things from minor version to minor version, such as changing cop names.

@kbrock
Copy link

kbrock commented May 16, 2019

Also, all channel names are hardcoded in the base code climate config [engine file], so it is a little more of a change than a simple "just automate it"

@marcelotoledo5000
Copy link
Contributor

I tried to update, but I had a problem, if can anyone help me to fix it, after this, anyone needs to accept the PR... I don't know what happened with the last PR before mine, is OK, but was not accepted yet.

#171

@modosc modosc changed the title Rubocop 0.69 released Rubocop 0.70 released May 21, 2019
@Mange
Copy link

Mange commented May 23, 2019

NOTE: This issue was changed to ask for 0.70 instead of 0.69.

(This comment should also trigger a notification for any subscribers to this issue.)

@marcelotoledo5000
Copy link
Contributor

@modosc
Copy link
Author

modosc commented May 30, 2019

looks like this is live now?

@Mange
Copy link

Mange commented May 31, 2019

Sure looks like it. I suggest closing this issue.
channel/rubocop-0-69...channel/rubocop-0-70

[EDIT]: I get this, though:

bin/codeclimate validate-config
WARNING: unknown engine or channel <rubocop:rubocop-0-70>

It's pushed to the Docker repo, and I'm on the latest version of the codeclimate/codeclimate image, so I don't understand why it won't install.

@modosc modosc closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants