Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop-performance back #189

Merged
merged 1 commit into from Jun 5, 2019
Merged

Add rubocop-performance back #189

merged 1 commit into from Jun 5, 2019

Conversation

filipesperandio
Copy link
Contributor

No description provided.

@codeclimate-hermes codeclimate-hermes requested review from nporteschaikin and removed request for codeclimate-hermes June 5, 2019 12:30
@filipesperandio filipesperandio requested review from ale7714 and removed request for nporteschaikin June 5, 2019 12:36
@Mange
Copy link

Mange commented Jun 5, 2019

I'd love to get this into rubocop-0-71 too. 🙈
(In addition to rubocop-rails #188)

@filipesperandio
Copy link
Contributor Author

@Mange #192
Will look into rubocop-rails next.

@aleksandrlat
Copy link

Could you guys please merge this?

@filipesperandio filipesperandio merged commit a0a6c7a into channel/rubocop-0-70 Jun 5, 2019
@filipesperandio filipesperandio deleted the fe/rubocop-performance-0-70 branch June 5, 2019 15:03
This was referenced Jun 5, 2019
Closed
Closed
@filipesperandio
Copy link
Contributor Author

RE: #187 and https://github.com/codeclimate-support/escalations/issues/634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mange Mange Mange approved these changes

@ale7714 ale7714 Awaiting requested review from ale7714

Assignees

@efueger efueger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filipesperandio @Mange @aleksandrlat @efueger