Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #2

Merged
merged 1 commit into from Mar 23, 2017
Merged

Update Dockerfile #2

merged 1 commit into from Mar 23, 2017

Conversation

nporteschaikin
Copy link
Contributor

  • Use standard node image (includes git)

@nporteschaikin
Copy link
Contributor Author

Tested this - it builds and runs.

@gdiggs
Copy link
Contributor

gdiggs commented Mar 23, 2017

What was the node version on the old image? What does this do to the size of the image?

Dockerfile Outdated
WORKDIR /root/

RUN apk --update add git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get a nice size bump if you add this into the next line:

RUN apk --update add git && \
      git clone https://github.com/etsy/statsd.git && \
      cd statsd && git reset --hard v0.7.2 && \
      apk del git && \
     npm install statsd-librato-backend statsd-datadog-backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nporteschaikin
Copy link
Contributor Author

Glad you asked. Using node was a mistake; it's massive (>700 MB). Moved to a tagged version of alpine. 20 MB on master, 77.5 MB here.

@gdiggs
Copy link
Contributor

gdiggs commented Mar 23, 2017

Nice

- Use standard node:6.10 image (includes git)
@nporteschaikin
Copy link
Contributor Author

60 MB now.

@nporteschaikin nporteschaikin merged commit d297601 into master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants