New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile #2
Conversation
nporteschaikin
commented
Mar 23, 2017
- Use standard node image (includes git)
95b028a
to
35422dc
Compare
Tested this - it builds and runs. |
What was the node version on the old image? What does this do to the size of the image? |
35422dc
to
32f4c91
Compare
Dockerfile
Outdated
WORKDIR /root/ | ||
|
||
RUN apk --update add git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get a nice size bump if you add this into the next line:
RUN apk --update add git && \
git clone https://github.com/etsy/statsd.git && \
cd statsd && git reset --hard v0.7.2 && \
apk del git && \
npm install statsd-librato-backend statsd-datadog-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Glad you asked. Using |
Nice |
- Use standard node:6.10 image (includes git)
60 MB now. |
32f4c91
to
f965328
Compare