Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clover formatter #213

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fix clover formatter #213

merged 1 commit into from
Aug 23, 2017

Conversation

ale7714
Copy link
Contributor

@ale7714 ale7714 commented Aug 21, 2017

Clover formatter was expecting coverage data to look like:

<coverage generated="11111">
  <project timestamp="111111">
    <package>
      <file name="path1">
        <line num="23" type="stmt" count="0"/>
      </file>
      <file name="path2">
        <line num="2" type="stmt" count="0"/>
      </file>
    </package>
  </project>
</coverage>

But a valid syntax is to also have files without the package tag wrapping them, like this:

<coverage generated="11111">
  <project timestamp="111111">
    <file name="path1">
      <line num="23" type="stmt" count="0"/>
    </file>
    <file name="path2">
      <line num="2" type="stmt" count="0"/>
    </file>
  </project>
</coverage>

This PR adds supports for that

Copy link
Contributor

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Just a general comment that it's difficult to review unfamiliar code when all of the variables are one or two letter abbreviations.

Maybe we can flesh out these variable names so the code is easier to digest?

@ale7714
Copy link
Contributor Author

ale7714 commented Aug 23, 2017

@dblandin completely agree. Being making a conscious to use better var names.

@ale7714 ale7714 merged commit e274fd3 into master Aug 23, 2017
@ale7714 ale7714 deleted the fix-clover branch August 23, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants