Lcov: benchmark & performance work #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated as useful by #264
|
|
While investigating #264, this popped out as low-hanging fruit: calling `CalcLineCounts` on a source file repeatedly is just wasted work. In fact, I don't think the formatter needs to call this method at all: it's already called by `Reporter.AddSourceFile`. (It's also called by `SourceFile.MarshalJSON`, so I think there's more inefficiency there to root out, but we can at least get down to calling it 2 times rather than `LOC + 2` times.)
Similar to the previous commit, looking for perf wins this is another bit of low hanging fruit: `HEAD` should not change while the test reporter is running. (If it did, I don't think we can even guarantee any kind of sensible results.)
wfleming
force-pushed
the
will/lcov-perf
branch
from
fb757b9
to
976c0ca
Compare
wfleming
commented
Dec 6, 2017
| @@ -64,7 +65,6 @@ func (r Formatter) Format() (formatters.Report, error) { | |||
| } | |||
| for ln-curLine >= 1 { | |||
| sf.Coverage = append(sf.Coverage, formatters.NullInt{}) | |||
| sf.CalcLineCounts() | |||
There was a problem hiding this comment.
good catcht! looks good to me
ale7714
reviewed
Dec 6, 2017
| var sf formatters.SourceFile | ||
| curLine := 1 | ||
|
|
||
| for _, line := range bytes.Split(b, []byte("\n")) { | ||
| if bytes.HasPrefix(line, []byte("SF:")) { | ||
| name := string(bytes.TrimSpace(bytes.TrimPrefix(line, []byte("SF:")))) | ||
| var gitHead, _ = env.GetHead() |
There was a problem hiding this comment.
nice! this was a super oversight on my part 🤦♀️
i think we can probably improve this on other formatters as well.
|
@wfleming you can run |
wfleming
changed the title
|
@ale7714 I haven't revisited this, but It think the changes as-is are worth shipping out for some improvements. Can you reviews this when you're back next week? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made while investigating #264, please see commits for details.