Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for excoveralls json format #278

Merged
merged 3 commits into from Dec 19, 2017
Merged

Conversation

@ale7714
Copy link
Contributor

@ale7714 ale7714 commented Dec 19, 2017

Related to parroty/excoveralls#119

@ale7714 ale7714 requested a review from codeclimate-hermes Dec 19, 2017
@codeclimate-hermes codeclimate-hermes requested review from toddmazierski and removed request for codeclimate-hermes Dec 19, 2017
@ale7714 ale7714 changed the title Add support to excoveralls json format Add support for excoveralls json format Dec 19, 2017
Copy link
Contributor

@toddmazierski toddmazierski left a comment

Looks good! Just a couple comments.

COPY . .
RUN go install -v

RUN git clone https://github.com/ale7714/excoveralls.git

This comment has been minimized.

@toddmazierski

toddmazierski Dec 19, 2017
Contributor

Should this be hosted on the codeclimate account?

This comment has been minimized.

@ale7714

ale7714 Dec 19, 2017
Author Contributor

gonna go with codecliamte-testing, since we're only using this for testing. Not really any development.

r.Equal(lc.Covered, 14)
r.Equal(lc.Missed, 1)
r.Equal(lc.Total, 15)
}

This comment has been minimized.

@toddmazierski

toddmazierski Dec 19, 2017
Contributor

Do you think it'd be worth adding coverage for the could not find any files, could not open coverage file states, too?

@ale7714 ale7714 force-pushed the ap-add-support-for-excoveralls branch from a106063 to 8b0eed4 Dec 19, 2017
@ale7714 ale7714 merged commit 07c806d into master Dec 19, 2017
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@ale7714 ale7714 deleted the ap-add-support-for-excoveralls branch Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants