Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional JACOCO_SOURCE_PATH env variable #318

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

toddmazierski
Copy link
Contributor

Add an optional JACOCO_SOURCE_PATH environment variable to fix bug where sometimes the path to source code can't be inferred.

Example usage:

JACOCO_SOURCE_PATH=src/main/java ./cc-test-reporter \
  format-coverage target/site/jacoco/jacoco.xml     \
  --input-type jacoco

Addresses #259.

Add an optional `JACOCO_SOURCE_PATH` environment variable to fix
bug where sometimes the path to source code can't be inferred.

Example usage:

    JACOCO_SOURCE_PATH=src/main/java ./cc-test-reporter \
      format-coverage target/site/jacoco/jacoco.xml     \
      --input-type jacoco

Addresses #259.
Copy link
Contributor

@ale7714 ale7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👏

@@ -52,7 +52,7 @@ var formatterMap = map[string]formatters.Formatter{

// formatCoverageCmd represents the format command
var formatCoverageCmd = &cobra.Command{
Use: "format-coverage",
Use: "format-coverage [coverage file]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@toddmazierski toddmazierski merged commit de2544d into master Mar 19, 2018
@toddmazierski toddmazierski deleted the todd/259-jacoco-paths branch March 19, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants