New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown files and warn #382

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
1 participant
@ale7714
Copy link
Member

ale7714 commented Jan 18, 2019

This will help with users using JaCoCo and Kotlin where the report includes "source files" for inline functions as is they were real files but they don't exist on the repo. We will emit a warning and skip.

@ale7714 ale7714 requested a review from codeclimate-hermes Jan 18, 2019

@codeclimate-hermes codeclimate-hermes requested review from eutopian and removed request for codeclimate-hermes Jan 18, 2019

@ale7714

This comment has been minimized.

Copy link
Member Author

ale7714 commented Jan 18, 2019

An user has been testing the changes for almost a week by now without reporting an issue. I'm gonna follow up with a release PR.

@ale7714 ale7714 merged commit 813301b into master Jan 18, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@ale7714 ale7714 deleted the ap/skip-files branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment