Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xccov support #399

Merged
merged 1 commit into from Jul 31, 2019
Merged

Add xccov support #399

merged 1 commit into from Jul 31, 2019

Conversation

ale7714
Copy link
Contributor

@ale7714 ale7714 commented Jul 22, 2019

Copy link
Contributor

@maxjacobson maxjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📱 nice!

sourceFile, err := formatters.NewSourceFile(jsonFile.Path, gitHead)
if err != nil {
logrus.Warnf("Couldn't find file for path \"%s\" from %s coverage data. Ignore if the path doesn't correspond to an existent file in your repo.", jsonFile.Path, r.Path)
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'm confused by: we have a test here, which is passing, but if I'm reading these lines right, we skip over non-existent files. But the test doesn't supply those files, only the report.

Edit: oh... I see... we overwrite the function that looks up the git blob, in the test... Neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants