Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xccov support #399

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@ale7714 ale7714 force-pushed the ap/xccov branch from a5100b7 to fbfcd05 Jul 23, 2019

@maxjacobson
Copy link
Member

left a comment

📱 nice!

sourceFile, err := formatters.NewSourceFile(jsonFile.Path, gitHead)
if err != nil {
logrus.Warnf("Couldn't find file for path \"%s\" from %s coverage data. Ignore if the path doesn't correspond to an existent file in your repo.", jsonFile.Path, r.Path)
continue

This comment has been minimized.

Copy link
@maxjacobson

maxjacobson Jul 31, 2019

Member

One thing I'm confused by: we have a test here, which is passing, but if I'm reading these lines right, we skip over non-existent files. But the test doesn't supply those files, only the report.

Edit: oh... I see... we overwrite the function that looks up the git blob, in the test... Neat

@ale7714 ale7714 merged commit 3ee4f71 into master Jul 31, 2019

2 checks passed

build_deploy Workflow: build_deploy
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.