Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer Levels on Profile contains other levels #2325

Closed
Vlevo opened this issue Feb 16, 2015 · 8 comments
Closed

Multiplayer Levels on Profile contains other levels #2325

Vlevo opened this issue Feb 16, 2015 · 8 comments

Comments

@Vlevo
Copy link
Contributor

Vlevo commented Feb 16, 2015

There are several levels listed in my "Profile | Multiplayer Levels" that are neither multiplayer nor repeatable (while the repeatables aren't "multiplayer" per say, I can see those maybe belonging there) such as "The Raised Sword", "Seige of Stonehold", "Mad Maxer", etc.

@nwinter nwinter added the bug label Feb 16, 2015
@nwinter
Copy link
Contributor

nwinter commented Feb 16, 2015

Right! The problem is that the isMultiplayer check is wrong, since we have teams defined for many sessions now: https://github.com/codecombat/codecombat/blob/master/app/models/LevelSession.coffee#L41-L41

Not exactly what it should be instead, but something better than just the team check. Maybe only when there is submittedCode? Won't show them up as multiplayer until the players submit at least once, but that's better than this.

I guess I'l just try that.

@Vlevo
Copy link
Contributor Author

Vlevo commented Feb 16, 2015

Those levels still appear in my "Profile | Multiplayer levels" list. :-(

Is this a not yet in production issue?

@sotonin
Copy link
Contributor

sotonin commented Feb 16, 2015

I'm still seeing a slew of single player ones listed under multiplayer as well. even on direct.

@Vlevo
Copy link
Contributor Author

Vlevo commented Feb 16, 2015

I don't know what qualifies as "submitted" code but, a lot of levels have a "submit" button.
Only "multiplayer" levels seem have a score. (of course this would also cut out the levels that one has never sucessfully submitted.)

@nwinter
Copy link
Contributor

nwinter commented Feb 17, 2015

I have not deployed to production yet, no.

@Vlevo
Copy link
Contributor Author

Vlevo commented Feb 17, 2015

Am I right in assuming it just went live??
Since it now says:

Multiplayer Levels
No Multiplayer games played yet.

Which isn't true.

@nwinter
Copy link
Contributor

nwinter commented Feb 17, 2015

Have you submitted the multiplayer games to the ladder? Which levels aren't showing up that should, and what's your username? I'll check it out.

@Vlevo
Copy link
Contributor Author

Vlevo commented Feb 17, 2015

I just checked again: Fixed


Username is the same :) Vlevo

Well, I guess I am only assuming that these are "multiplayer" since they are ladder games:

Cavern Survival
Multiplayer Treasure Grove
Dueling Grounds

They all show up now...

Are there any other on the map ladder games?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants