Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just use VM, not docker, to reduce time #21

Closed
jjangga0214 opened this issue Sep 20, 2019 · 2 comments
Closed

Just use VM, not docker, to reduce time #21

jjangga0214 opened this issue Sep 20, 2019 · 2 comments

Comments

@jjangga0214
Copy link

jjangga0214 commented Sep 20, 2019

This spends time a LOT (about 90s).

RUN apt update && apt install -y curl git mercurial

However, Github VMs already have curl, git and Mercurial preinstalled. Check them out here.

So, there is no need to use docker at all. Just run entrypoint.sh directly.

@jjangga0214 jjangga0214 changed the title Just use VM, not docker Just use VM, not docker, to reduce time Sep 20, 2019
chetanmeh added a commit to adobe/github-reporter that referenced this issue Sep 20, 2019
As mentioned in codecov/codecov-action#21 the default action impl rebuilds whole docker image which takes time. As the actual upload is simple bash command we use that directly
@chetanmeh
Copy link

As a workaround for long time taken directly using the curl command also works

    - name: Build with Gradle
      env:
        CI: "true"
        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
      run: |
        ./gradlew checkScalafmtAll reportTestScoverage
        curl -s https://codecov.io/bash | bash -s -- -t $CODECOV_TOKEN

@ibrahim0814
Copy link
Contributor

Hi all,

We introduced v1.0.4 of our Codecov action today that does away with Docker images entirely and uses JavaScript instead. It has significantly better performance than our previous Docker based action and also supports Windows + macOS builds.

My apologies that it took us so long to address your concerns about Docker

Ib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants