Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pull_request id env variable #53

Merged
merged 11 commits into from
Mar 5, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 1, 2020

I did small refactoring of code as everything was typed there 4 times

cc @drazisil @ibrahim0814
fixes #52

@ibrahim0814
Copy link
Contributor

Hi @armano2! Thank you for taking the time to make this pull request! Unfortunately, the changes you made need to be reflected on our bash uploader instead of in this repository. I've made a similar PR on our bash uploader that fixes incorrect PR handling for GitHub Actions here: codecov/codecov-bash#263

For this repository, the only change that needs to be made is to add the GITHUB_HEAD_REF environment variable if it exists.

Copy link
Contributor

@ibrahim0814 ibrahim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@armano2
Copy link
Contributor Author

armano2 commented Feb 7, 2020

ok i will update PR, thank you for feedback

@armano2
Copy link
Contributor Author

armano2 commented Feb 7, 2020

@ibrahim0814 updated, i'm unsure why ncc outputs packages in different order in dist

index.js Outdated Show resolved Hide resolved
@ibrahim0814
Copy link
Contributor

Going to be adding a few commits to your changes here @armano2! Currently removing the yml parameter since we're having a ton of issues with yaml validation on our end. Nothing to do with your changes but thought I'd roll it in together since I want to release a new version of this action soon

@ibrahim0814
Copy link
Contributor

Will also be adding in documentation and code to accommodate tokenless functionality for Actions in this PR

@ibrahim0814 ibrahim0814 merged commit d7c91c5 into codecov:master Mar 5, 2020
@armano2 armano2 deleted the branch-support branch April 8, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of PR builds from GitHub Actions.
2 participants