-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing pull_request id env variable #53
Conversation
Hi @armano2! Thank you for taking the time to make this pull request! Unfortunately, the changes you made need to be reflected on our bash uploader instead of in this repository. I've made a similar PR on our bash uploader that fixes incorrect PR handling for GitHub Actions here: codecov/codecov-bash#263 For this repository, the only change that needs to be made is to add the GITHUB_HEAD_REF environment variable if it exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
ok i will update PR, thank you for feedback |
54978d7
to
44ca3d2
Compare
@ibrahim0814 updated, i'm unsure why ncc outputs packages in different order in dist |
Going to be adding a few commits to your changes here @armano2! Currently removing the |
Will also be adding in documentation and code to accommodate tokenless functionality for Actions in this PR |
I did small refactoring of code as everything was typed there 4 times
cc @drazisil @ibrahim0814
fixes #52