dev: Enable most F rules for Ruff (#574)

codecov/settings_base.py

@@ -1,6 +1,7 @@
 import os
 from urllib.parse import urlparse
 
+import django_prometheus
 import sentry_sdk
 from corsheaders.defaults import default_headers
 from sentry_sdk.integrations.celery import CeleryIntegration
@@ -252,7 +253,7 @@
         }
 
 # See https://django-postgres-extra.readthedocs.io/en/master/settings.html
-POSTGRES_EXTRA_DB_BACKEND_BASE: "django_prometheus.db.backends.postgresql"
+POSTGRES_EXTRA_DB_BACKEND_BASE: "django_prometheus.db.backends.postgresql"  # type: ignore
 
 # Allows to use the pgpartition command
 PSQLEXTRA_PARTITIONING_MANAGER = (

core/commands/pull/interactors/tests/test_fetch_pull_requests.py

@@ -3,7 +3,6 @@
 from django.contrib.auth.models import AnonymousUser
 from django.test import TransactionTestCase
 
-from api.internal import pull
 from core.models import PullStates
 from core.tests.factories import OwnerFactory, PullFactory, RepositoryFactory
 from reports.tests.factories import UploadFactory

graphql_api/tests/test_owner.py

@@ -16,7 +16,7 @@
     OwnerFactory,
     UserFactory,
 )
-from core.tests.factories import CommitFactory, OwnerFactory, RepositoryFactory
+from core.tests.factories import CommitFactory, RepositoryFactory
 from plan.constants import PlanName, TrialStatus
 from reports.tests.factories import CommitReportFactory, UploadFactory
 

graphql_api/tests/test_owner_measurements.py

@@ -2,7 +2,6 @@
 from unittest.mock import patch
 
 from django.test import TransactionTestCase, override_settings
-from django.utils import timezone
 
 from codecov_auth.tests.factories import OwnerFactory
 from core.tests.factories import RepositoryFactory

graphql_api/tests/test_plan.py

@@ -5,7 +5,6 @@
 from freezegun import freeze_time
 
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import OwnerFactory
 from plan.constants import PlanName, TrialStatus
 
 from .helper import GraphQLTestHelper

graphql_api/tests/test_plan_representation.py

@@ -5,7 +5,6 @@
 from freezegun import freeze_time
 
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import OwnerFactory
 from plan.constants import PlanName, TrialStatus
 
 from .helper import GraphQLTestHelper

graphql_api/tests/test_repository_measurements.py

@@ -2,7 +2,6 @@
 from unittest.mock import patch
 
 from django.test import TransactionTestCase, override_settings
-from django.utils import timezone
 
 from codecov_auth.tests.factories import OwnerFactory
 from core.tests.factories import RepositoryFactory

graphql_api/types/__init__.py

@@ -24,7 +24,7 @@
 from .component_comparison import component_comparison, component_comparison_bindable
 from .config import config, config_bindable
 from .coverage_totals import coverage_totals, coverage_totals_bindable
-from .enums import enum_types, enums
+from .enums import enum_types
 from .file import commit_file, file_bindable
 from .flag import flag, flag_bindable
 from .flag_comparison import flag_comparison, flag_comparison_bindable

graphql_api/types/commit/commit.py

@@ -31,7 +31,7 @@
     MissingHeadReport,
 )
 from graphql_api.types.enums import OrderingDirection, PathContentDisplayType
-from graphql_api.types.errors import MissingCoverage, MissingHeadReport, UnknownPath
+from graphql_api.types.errors import MissingCoverage, UnknownPath
 from graphql_api.types.errors.errors import UnknownFlags
 from services.bundle_analysis import BundleAnalysisComparison, BundleAnalysisReport
 from services.comparison import Comparison, ComparisonReport

graphql_api/types/mutation/mutation.py

@@ -1,7 +1,5 @@
 from ariadne import MutationType
 
-from graphql_api.types.mutation.start_trial.start_trial import resolve_start_trial
-
 from .activate_measurements import (
     error_activate_measurements,
     resolve_activate_measurements,

ruff.toml

@@ -37,8 +37,8 @@ target-version = "py312"
 
 [lint]
 # Currently only enabled for F541 and I: https://docs.astral.sh/ruff/rules/
-select = ["F541", "I"]
-ignore = []
+select = ["F", "I"]
+ignore = ["F841", "F401", "F405", "F403"]
 
 # Allow fix for all enabled rules (when `--fix`) is provided.
 # The preferred method (for now) w.r.t. fixable rules is to manually update the makefile

services/yaml.py

@@ -4,7 +4,6 @@
 
 from asgiref.sync import async_to_sync
 from shared.yaml import UserYaml, fetch_current_yaml_from_provider_via_reference
-from shared.yaml.user_yaml import UserYaml
 from shared.yaml.validation import validate_yaml
 from yaml import safe_load
 

timeseries/tests/test_helpers.py

@@ -4,7 +4,6 @@
 import pytest
 from django.conf import settings
 from django.test import TransactionTestCase
-from django.utils import timezone
 from freezegun import freeze_time
 from freezegun.api import FakeDatetime
 from shared.reports.resources import Report, ReportFile, ReportLine

upload/tests/test_upload.py

@@ -1065,7 +1065,6 @@ async def get_commit(self, commit, token):
             "reportid": "dec1f00b-1883-40d0-afd6-6dcb876510be",
             "redis_key": "upload/b521e55/dec1f00b-1883-40d0-afd6-6dcb876510be/plain",
             "url": None,
-            "branch": None,
             "job": None,
         }
 
@@ -1143,7 +1142,6 @@ async def get_commit(self, commit, token):
             "reportid": "dec1f00b-1883-40d0-afd6-6dcb876510be",
             "redis_key": "upload/b521e55/dec1f00b-1883-40d0-afd6-6dcb876510be/plain",
             "url": None,
-            "branch": None,
             "job": None,
         }