Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused events #116

Merged
merged 4 commits into from
Sep 19, 2023
Merged

removing unused events #116

merged 4 commits into from
Sep 19, 2023

Conversation

dana-yaish
Copy link
Contributor

@dana-yaish dana-yaish commented Sep 7, 2023

Purpose/Motivation

Removing non used events from the code. You can access the whole investigation in here

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Sep 7, 2023

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #116 (ad675f6) into main (5cd92f6) will not change coverage.
The diff coverage is 97.89%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

@@          Coverage Diff          @@
##            main    #116   +/-   ##
=====================================
  Coverage   95.37   95.37           
=====================================
  Files        705     706    +1     
  Lines      15101   15133   +32     
=====================================
+ Hits       14402   14432   +30     
- Misses       699     701    +2     
Flag Coverage Δ
unit 95.52% <97.82%> (-0.05%) ⬇️
unit-latest-uploader 95.52% <97.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
api/internal/owner/serializers.py 100.00% <ø> (ø)
api/internal/owner/views.py 97.75% <ø> (-0.05%) ⬇️
api/internal/repo/views.py 100.00% <ø> (ø)
billing/views.py 94.57% <ø> (-0.50%) ⬇️
plan/service.py 95.95% <ø> (-0.16%) ⬇️
profiling/views.py 100.00% <ø> (ø)
services/activation.py 92.85% <ø> (-0.25%) ⬇️
services/billing.py 92.59% <ø> (-0.21%) ⬇️
webhook_handlers/views/github.py Critical 98.87% <ø> (-0.02%) ⬇️
api/internal/repo/serializers.py 98.07% <66.66%> (-1.93%) ⬇️
... and 4 more

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Lots of code removed.
Left 2 comments, but it's ok

plan/service.py Show resolved Hide resolved
webhook_handlers/views/github.py Show resolved Hide resolved
@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 18, 2023

Codecov Report

Merging #116 (ad675f6) into main (5cd92f6) will decrease coverage by 0.05%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   95.49%   95.45%   -0.05%     
==========================================
  Files         591      591              
  Lines       14889    14733     -156     
==========================================
- Hits        14218    14063     -155     
+ Misses        671      670       -1     
Flag Coverage Δ
unit 95.45% <97.82%> (-0.05%) ⬇️
unit-latest-uploader 95.45% <97.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
api/internal/owner/serializers.py 98.98% <ø> (-0.02%) ⬇️
api/internal/owner/views.py 97.75% <ø> (-0.05%) ⬇️
api/internal/repo/views.py 100.00% <ø> (ø)
billing/views.py 94.57% <ø> (-0.50%) ⬇️
plan/service.py 94.94% <ø> (-1.17%) ⬇️
profiling/views.py 100.00% <ø> (ø)
services/activation.py 92.85% <ø> (-0.25%) ⬇️
services/billing.py 92.59% <ø> (-0.21%) ⬇️
webhook_handlers/views/github.py 98.87% <ø> (-0.02%) ⬇️
api/internal/repo/serializers.py 96.15% <66.66%> (-3.85%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

Impacted file tree graph

@dana-yaish dana-yaish merged commit 2ea7769 into main Sep 19, 2023
20 of 23 checks passed
@dana-yaish dana-yaish deleted the dana/removing-unused-events branch September 19, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants