-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing unused events #116
Conversation
7b6eb8c
to
4cbe1f4
Compare
4cbe1f4
to
6a0b94d
Compare
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #116 +/- ##
=====================================
Coverage 95.37 95.37
=====================================
Files 705 706 +1
Lines 15101 15133 +32
=====================================
+ Hits 14402 14432 +30
- Misses 699 701 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Lots of code removed.
Left 2 comments, but it's ok
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 95.49% 95.45% -0.05%
==========================================
Files 591 591
Lines 14889 14733 -156
==========================================
- Hits 14218 14063 -155
+ Misses 671 670 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
Removing non used events from the code. You can access the whole investigation in here
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.