Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit does not have repoid, should be commit.repository.repoid #136

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

dana-yaish
Copy link
Contributor

fixing a small bug

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #136 (fb09d9c) into main (94a9579) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #136   +/-   ##
=====================================
  Coverage   95.37   95.37           
=====================================
  Files        704     704           
  Lines      15096   15096           
=====================================
  Hits       14397   14397           
  Misses       699     699           
Flag Coverage Δ
unit 95.55% <ø> (ø)
unit-latest-uploader 95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
upload/views/commits.py 100.00% <ø> (ø)
upload/views/empty_upload.py 89.47% <ø> (ø)

@codecov-staging
Copy link

codecov-staging bot commented Sep 14, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
upload/views/commits.py ø
upload/views/empty_upload.py ø

📢 Thoughts on this report? Let us know!.

@codecov-public-qa
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@codecov-staging
Copy link

codecov-staging bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
upload/views/commits.py ø
upload/views/empty_upload.py ø

📢 Thoughts on this report? Let us know!.

@dana-yaish dana-yaish merged commit 9b23dd3 into main Sep 18, 2023
22 of 23 checks passed
@dana-yaish dana-yaish deleted the dana/fix-log branch September 18, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants